On Mon, Jan 29, 2024 at 11:23 PM Patrick Steinhardt <ps@xxxxxx> wrote: > > In 1df18a1c9a (reftable: honor core.fsync, 2024-01-23), we have added > code to fsync both newly written reftables as well as "tables.list" to > disk. But there are two code paths where "tables.list" is being written: > > - When appending a new table due to a normal ref update. > > - When compacting a range of tables during compaction. > > We have only addressed the former code path, but do not yet sync the new > "tables.list" file in the latter. Fix this ommission. nit: s/ommission/omission > > Note that we are not yet adding any tests. These tests will be added > once the "reftable" backend has been upstreamed. > Nice catch! I noticed a small typo in the commit message but otherwise looks good to me. -Justin
