On Fri, Jan 26, 2024 at 4:09 AM Patrick Steinhardt <ps@xxxxxx> wrote: > > When creating a new compacted table from a range of preexisting ones we > don't set the default permissions on the resulting table when specified > by the user. This has the effect that the "core.sharedRepository" config > will not be honored correctly. > > Fix this bug and add a test to catch this issue. Note that we only test > on non-Windows platforms because Windows does not use POSIX permissions > natively. > > Signed-off-by: Patrick Steinhardt <ps@xxxxxx> > --- > > Changes compared to v2: > > - Extended the commit message to say why we don't test on Windows > systems. > > - Renamed the `scratch` variable to `path`. Thanks Patrick! This version looks good to me. I have nothing else to add -Justin
