Right now it is infeasible to offer to the user a reasonable concept
of when a clone will be complete as we aren't able to come up with
the final pack size until after we have actually transferred the
entire thing to the client. However in many cases users can work
with a rough rule-of-thumb; for example it is somewhat well known
that git.git is about 16 MiB today and that linux-2.6.git is over
120 MiB.
We now show the total amount of data we have transferred over
the network as part of the throughput meter, organizing it in
"human friendly" terms like `ls -h` would do. Users can glance at
this, see that the total transferred size is about 3 MiB, see the
throughput of X KiB/sec, and determine a reasonable figure of about
when the clone will be complete, assuming they know the rough size
of the source repository or are able to obtain it.
This is also a helpful indicator that there is progress being made
even if we stall on a very large object. The thoughput meter may
remain relatively constant and the percentage complete and object
count won't be changing, but the total transferred will be increasing
as additional data is received for this object.
Signed-off-by: Shawn O. Pearce <spearce@xxxxxxxxxxx>
---
This follows on top of Nico's 5 patch series to add the thoughput
meter. I think its a useful addition.
progress.c | 32 +++++++++++++++++++++++++++++---
1 files changed, 29 insertions(+), 3 deletions(-)
diff --git a/progress.c b/progress.c
index 23ee9f3..5c95091 100644
--- a/progress.c
+++ b/progress.c
@@ -11,7 +11,11 @@ struct throughput {
unsigned int avg_misecs;
unsigned int last_misecs[TP_IDX_MAX];
unsigned int idx;
- char display[20];
+ unsigned int unit_size;
+ unsigned int unit_index;
+ unsigned int total_units;
+ unsigned int curr_bytes;
+ char display[40];
};
struct progress {
@@ -24,6 +28,7 @@ struct progress {
struct throughput *throughput;
};
+static const char *units[] = {"bytes", "KiB", "MiB", "GiB"};
static volatile sig_atomic_t progress_update;
static void progress_interval(int signum)
@@ -113,12 +118,27 @@ void display_throughput(struct progress *progress, unsigned long n)
if (!tp) {
progress->throughput = tp = calloc(1, sizeof(*tp));
- if (tp)
+ if (tp) {
tp->prev_tv = tv;
+ tp->unit_size = 1;
+ }
return;
}
tp->count += n;
+ tp->curr_bytes += n;
+ if (tp->curr_bytes > tp->unit_size) {
+ tp->total_units += tp->curr_bytes / tp->unit_size;
+ tp->curr_bytes = tp->curr_bytes % tp->unit_size;
+
+ while (tp->total_units >= 1024
+ && tp->unit_index < ARRAY_SIZE(units)) {
+ tp->curr_bytes += (tp->total_units % 1024) * tp->unit_size;
+ tp->total_units = tp->total_units / 1024;
+ tp->unit_size *= 1024;
+ tp->unit_index++;
+ }
+ }
/*
* We have x = bytes and y = microsecs. We want z = KiB/s:
@@ -143,7 +163,13 @@ void display_throughput(struct progress *progress, unsigned long n)
tp->avg_bytes += tp->count;
tp->avg_misecs += misecs;
snprintf(tp->display, sizeof(tp->display),
- ", %lu KiB/s", tp->avg_bytes / tp->avg_misecs);
+ ", %3u.%2.2u %s %lu KiB/s",
+ tp->total_units,
+ tp->unit_size > 1
+ ? tp->curr_bytes / (tp->unit_size / 100)
+ : 0,
+ units[tp->unit_index],
+ tp->avg_bytes / tp->avg_misecs);
tp->avg_bytes -= tp->last_bytes[tp->idx];
tp->avg_misecs -= tp->last_misecs[tp->idx];
tp->last_bytes[tp->idx] = tp->count;
--
1.5.3.4.1481.g854da
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
