On Thu, Jan 18, 2024 at 10:05 PM Patrick Steinhardt <ps@xxxxxx> wrote: > > On Thu, Jan 18, 2024 at 11:43:18AM -0900, Britton Leo Kerin wrote: > > CC to add: CC: Junio C Hamano <gitster@xxxxxxxxx>, Patrick Steinhardt <ps@xxxxxx> > > > > Relative to v2 this only changes a wrong misleading commit message. > > > > Bring completion for bisect up to date with current features. > > Thanks for your patches! I've got a few comments to bring them more in > line with how we're doing things in the Git project, but I agree with > the overall direction that they are going into. > > It might be a good idea to also add a few tests in t9902-completion.sh > to ensure that the newly introduced completions work as expected. Thanks for the review, other than the one philosophical issue about how functions should be introduced/moved I agree with everything you said and will rework the series accordingly. Britton
