"Md Isfarul Haque via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes:
> From: Md Isfarul Haque <isfarul.876@xxxxxxxxx>
>
> Signed-off-by: Md Isfarul Haque <isfarul.876@xxxxxxxxx>
> ---
> diff.c | 1 +
> 1 file changed, 1 insertion(+)
We do not need to see that you are just as human as other developers
and are prone to make mistakes that you need to fix it in a
follow-up. In other words, please do not introduce a bug in [1/2]
only to be fixed in [2/2]. By squashing these two patches into one,
you can pretend as if you are a perfect developer and never leaked
memory ;-).
> diff --git a/diff.c b/diff.c
> index e3223b8ce5b..9fa00103a6b 100644
> --- a/diff.c
> +++ b/diff.c
> @@ -2309,6 +2309,7 @@ const struct strbuf *diff_line_prefix_buf(struct diff_options *opt)
> msgbuf->alloc = 1;
> }
> else {
> + free(msgbuf);
> msgbuf = opt->output_prefix(opt, opt->output_prefix_data);
> }
> return msgbuf;
But as I said, I do not see a need for this helper function in the
first place, so...
