On Wed, Jan 24, 2024 at 3:04 PM Md Isfarul Haque via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > > From: Md Isfarul Haque <isfarul.876@xxxxxxxxx> > > This patch adresses diff.c:2721 and proposes the fix using a new function. Please give more details here about what is currently at diff.c:2721 and what the patch is fixing, as lines at diff.c:2721 could move to a different location if some changes are made to diff.c before your patches get merged or after they get merged. Also if the patch is addressing an issue in a code comment I would expect the corresponding code comment to be removed by the patch. About the subject, maybe "diff: use utf8_strnwidth() for line_prefix" is already better. > Signed-off-by: Md Isfarul Haque <isfarul.876@xxxxxxxxx> > --- > diff.c | 18 ++++++++++++++++-- > diff.h | 1 + > 2 files changed, 17 insertions(+), 2 deletions(-) > > diff --git a/diff.c b/diff.c > index a89a6a6128a..e3223b8ce5b 100644 > --- a/diff.c > +++ b/diff.c > @@ -2300,6 +2300,20 @@ const char *diff_line_prefix(struct diff_options *opt) > return msgbuf->buf; > } > > +const struct strbuf *diff_line_prefix_buf(struct diff_options *opt) This function seems to be used only in diff.c, so it could be static.
