On Thu, Jan 18, 2024 at 02:41:56PM +0100, Patrick Steinhardt wrote: > Refactor the code to stop using `stat_validity_check()`. Instead, we > manually stat(3P) the file descriptors to make relevant information > available. On Windows and MSYS2 the result will have both `st_dev` and > `st_ino` set to 0, which allows us to address the first issue by not > using the stat-based cache in that case. It also allows us to make sure > that we always compare `st_dev` and `st_ino`, addressing the second > issue. I didn't think too hard about the details, but does this mean that every user of stat_validity_check() has the same issue? The other big one is packed-refs (for which the code was originally written). Should this fix go into that API? -Peff
