Patrick Steinhardt <ps@xxxxxx> writes: >> Add two tests to separately address cases where the URL check correctly >> filters out invalid URLs and cases where the check misses invalid URLs. Mark >> the latter ("url check misses invalid cases") with 'test_expect_failure' to >> indicate that this not the undesired behavior. > > Nit: this should probably say "to indicate that this is not the desired > behaviour." But given that the other patches in this series look good to > me I don't think this warrants a reroll. Good eyes. I'll rewrite that part to "... to indicate that this is currently broken, which will be fixed in the next step." before merging the series to 'next'. Thanks.