On Thu, Jan 18, 2024 at 11:43:22AM -0900, Britton Leo Kerin wrote:
Missing an explanation.
> Signed-off-by: Britton Leo Kerin <britton.kerin@xxxxxxxxx>
> ---
> contrib/completion/git-completion.bash | 15 ++++++++++++---
> 1 file changed, 12 insertions(+), 3 deletions(-)
>
> diff --git a/contrib/completion/git-completion.bash b/contrib/completion/git-completion.bash
> index 63ca8082a4..ad80df6630 100644
> --- a/contrib/completion/git-completion.bash
> +++ b/contrib/completion/git-completion.bash
> @@ -1583,10 +1583,19 @@ _git_bisect ()
> {
> __git_has_doubledash && return
>
> - local subcommands="start bad new good old terms skip reset visualize replay log run help"
> + __git_find_repo_path
> +
> + local term_bad term_good
> + if [ -f "$__git_repo_path"/BISECT_START ]; then
> + term_bad=`__git bisect terms --term-bad`
> + term_good=`__git bisect terms --term-good`
> + fi
We do not use backticks in our codebase. Please use `$(cmd ...)`
instead.
Patrick
> + local subcommands="start bad new $term_bad good old $term_good terms skip reset visualize replay log run help"
> +
> local subcommand="$(__git_find_on_cmdline "$subcommands")"
> +
> if [ -z "$subcommand" ]; then
> - __git_find_repo_path
> if [ -f "$__git_repo_path"/BISECT_START ]; then
> __gitcomp "$subcommands"
> else
> @@ -1619,7 +1628,7 @@ _git_bisect ()
> esac
>
> case "$subcommand" in
> - bad|new|good|old|reset|skip|start)
> + bad|new|"$term_bad"|good|old|"$term_good"|reset|skip|start)
> __git_complete_refs
> ;;
> *)
> --
> 2.43.0
>
Attachment:
signature.asc
Description: PGP signature
