On Tue, Jan 16, 2024 at 8:27 PM René Scharfe <l.s.r@xxxxxx> wrote: > > Am 16.01.24 um 16:38 schrieb Junio C Hamano: > > Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > > > >> Thanks for adding back the test for EOF, this version looks good to me. > > > > Thanks. Let's merge it to 'next'. > > OK. I'm still interested in replies to my question in > https://lore.kernel.org/git/a087f57c-ce72-45c7-8182-f38d0aca9030@xxxxxx/, > i.e. whether we should have one TEST per class or one per class and > character -- or in a broader sense: What's the ideal scope of a TEST? > But I can ask it again in the form of a follow-up patch. I think one test per character per class would result in too much detail in the output. Other than that I think it's better to address your questions to the designers of the unit test framework rather than to the authors of this patch. And yeah, sending a follow up patch would perhaps be the best. Thanks.
