On Thu, Jan 11, 2024 at 08:24:30PM +0000, Justin Tobler via GitGitGadget wrote: > - # the new branch should not have been created upstream > - test_must_fail git -C "$d" show-ref --verify refs/heads/atomic && > - > - # upstream should still reflect atomic2, the last thing we pushed > - # successfully > - git rev-parse atomic2 >expected && > - # ...to other. > - git -C "$d" rev-parse refs/heads/other >actual && > - test_cmp expected actual && > - > - # the new branch should not have been created upstream > + # The atomic and other branches should be created upstream. > test_must_fail git -C "$d" show-ref --verify refs/heads/atomic && > + test_must_fail git -C "$d" show-ref --verify refs/heads/other && This last comment should say "should not be created", I think? Other than that, both patches look good to me. -Peff
