On Thu, Jan 04, 2024 at 12:06:31AM -0800, Illia Bobyr wrote:
> Documentation should mention the default behavior.
>
> It is better to explain the persistent nature of the
> --reschedule-failed-exec flag from the user standpoint, rather than from
> the implementation standpoint.
The first paragraph looks good, and I think your wording is an
improvement over what's already there (though of course this is
subjective, and YMMV).
> +Recording this option for the whole rebase is a convenience feature. Otherwise
> +an explicit `--no-reschedule-failed-exec` at the start would be overridden by
> +the presence of a `rebase.rescheduleFailedExec=true` configuration when `git
> +rebase --continue` is invoked. Currently, you can not, pass
> +`--[no-]reschedule-failed-exec` to `git rebase --continue`.
The last sentence was a bit confusing to me. I assume you meant
Currently, you cannot pass `--[no-]reschedule-failed-exec` [...]
without the comma between "pass" and "`--[no]reschedule-failed-exect`",
and replacing "can not" with "cannot".
Thanks,
Taylor
