Phillip Wood <phillip.wood123@xxxxxxxxx> writes: > On 21/12/2023 20:58, Sean Allred wrote: >> Is there a current reason why pre-commit shouldn't be invoked during >> rebase, or is this just waiting for a reviewable patch? > > The reason that we don't run the pre-commit hook is that the commit > being rebased may have been created with "git commit --no-verify" and > so running the pre-commit hook would stop it from being rebased - see > e637122ef2 (rebase -m: do not trigger pre-commit verification, > 2008-03-16). Very true. And back then we didn't have "rebase -x" mechanism but these days, anybody who is interested in running a command between each step can use it to run any validation script, not the one with fixed name called "hooks", so I'd place this to fairly low priority. Thanks.
