Junio C Hamano wrote: > > From: Josh Soref <jsoref@xxxxxxxxx> > > > > The contents within parenthesis should be omittable without resulting > > in broken text. > > > > Eliding the parenthesis left a period to end a run without any content. > > Nobody seems to have commented on this one in the previous round, > but quite honestly, for this particular instance, I suspect that it > may become easier to read if we just lost these parentheses, as the > next sentence "You do not have to include more than ..." is just a > bit of extra material to support the first sentence like the one we > see in the parentheses. Alternatively, moving that "You do not have > to" also inside the same parentheses might work slightly better. > It might be even easier to follow if we moved the list of "approved > headers" (and the "You do not have to ... more than one" note that > supports the "currently approved list") totally out of line by > making it a side note. I think, in principle, it'd be better if it was its own thing, but the structure of this entire section makes this really hard -- I certainly can't imagine a way to do it. The laziest fix is: - The first #include in C files, except in platform specific compat/ implementations and sha1dc/, must be one of "git-compat-util.h", "builtin.h", "t/helper/test-tool.h", "xdiff/xinclude.h", or "reftable/system.h". Beyond that, I don't understand how to parse: You do not have to include more than one of these. (Sorry, I'd like to be slightly ignorant of the C parts of git -- let's ignore that I've been blamed for at least one change to them -- so, I'm not going to look.)
