Hi folks,
I have a problem with 'commit-graph verify' in poco repository ([1]).
A commit appeared there with an odd timestamp and time zone ([2]):
git show --no-patch --pretty=%ai
381ac1d9a82c9682a5046dd51802a687a81ace91
# 2106-02-07 06:28:18 -11309508
The main problem is that the 'commit-graph verify' return error:
git commit-graph write
git commit-graph verify
# commit-graph generation for commit
1763a5017d8c0a9af6094fde91c43a5722bbde4c is 1699836629 < 4702109779
# Verifying commits in commit graph: 100% (9489/9489), done.
echo $?
# 1
And this results in an error on fsck:
git fsck
# ...
# error in commit 381ac1d9a82c9682a5046dd51802a687a81ace91:
badTimezone: invalid author/committer line - bad time zone
# ...
# commit-graph generation for commit
1763a5017d8c0a9af6094fde91c43a5722bbde4c is 1699836629 < 4702109779
# ...
echo $?
# 20
I found that first error can be masked using 'fsck.skiplist' file. But
can't find how to mask the second.
Is there a workaround for this case?
System info:
* git version: 2.43.0
* OS: Debian GNU/Linux 11 (bullseye), x86_64
Notes:
* This error originally occurred on a local GitLab installation, that
periodically run fsck on all repos. And the poco repo mirror in our
GitLab instance is now marked as failed.
* Another strange thing about this commit is that git can't find any
belonging branch for it, but parent and child commits are has ones:
git log --pretty=format:"%h %ad | %s%d [%an]" --graph --date=short
-n10 4261-move-autocommit-abstractsession
# ac7e39ff8 2023-11-14 | Fixed indentation in ci.yml
(4261-move-autocommit-abstractsession) [Friedrich Wilckens]
# 543ea150a 2023-11-14 | Github workflow: re-activated
linux-gcc-make-postgres [Friedrich Wilckens]
# a2d10dffe 2023-11-13 | PostgreSQL SessionImpl: reuse autocommit
flag of AbstractSessionImpl. [Friedrich Wilckens]
# d32f62031 2023-11-13 | MySQL SessionImpl: make sure autocommit
mode is on when session is openend or reset. [Friedrich Wilckens]
# c919b7f79 2023-11-13 | chore(CI): re-enable mysql [Alex Fabijanic]
# ffd0007f2 2023-11-13 | fix(Data::AbstracSessionImpl): protect
autocommit feature handlers #4261 [Alex Fabijanic]
# 1763a5017 2023-11-12 | Brought MySQL backend in line with
_autoCommit flag of AbstractSessionImpl. [Friedrich Wilckens]
# 381ac1d9a 2106-02-07 | feat(Data::AbstractSessionImpl): add
autoCommit property and tests #4261 [Alex Fabijanic] <---
# 18eea1bb7 2023-11-11 | temporarily comment failing mysql ci until
fixed [Aleksandar Fabijanic]
# 6a5387ec2 2023-11-11 | add visitor pattern implementation for
Poco::Dynamic::Var (#4144) [Alexander B]
for _c in 1763a5017 381ac1d9a 18eea1bb7; do
echo "* $_c:";
git branch --contains=$_c | sed 's/^/ /';
done
# * 1763a5017:
# 4261-move-autocommit-abstractsession
# * 381ac1d9a:
# * 18eea1bb7:
#
2366-pocoprocesslaunch-unix-possible-memory-leak-when-launching-invalid-command
# 4261-move-autocommit-abstractsession
# 569-DateTimeParser-cherry-pick
# devel
Links:
[1]: https://github.com/pocoproject/poco
[2]:
https://github.com/pocoproject/poco/commit/381ac1d9a82c9682a5046dd51802a687a81ace91
