On 12/9/23 17:13, Junio C Hamano wrote:
so you could read that
git bisect terms --term-good
git bisect terms --term-old
are the same thing, and when you squint your eyes, you can probably
guess that
git bisect terms --term-bad
git bisect terms --term-new
are the same. But I agree that the documentation should not force
you to guess.
Agreed.
--- c/Documentation/git-bisect.txt
+++ w/Documentation/git-bisect.txt
@@ -20,7 +20,7 @@ on the subcommand:
[--no-checkout] [--first-parent] [<bad> [<good>...]] [--] [<paths>...]
git bisect (bad|new|<term-new>) [<rev>]
git bisect (good|old|<term-old>) [<rev>...]
- git bisect terms [--term-good | --term-bad]
+ git bisect terms [--term-(good|old) | --term-(bad|new)]
Nit: just above we have the description for `bisect start` saying:
--term-{new,bad}=<term> --term-{old,good}=<term>
it probably makes sense to make both homogeneous (start with the same
alternative, and make the {...,...} vs (...|...) notations consistent.
The (...|...) notation seems the most common).
In any case, the patch looks good to me, thanks.
--
Matthieu Moy
https://matthieu-moy.fr/
