On Thu, Dec 07, 2023 at 02:24:04AM -0500, Jeff King wrote: > If you feed nonsense config like: > > git -c core.checkstat=foobar status > > we'll silently ignore the unknown value, rather than reporting an error. > This goes all the way back to c08e4d5b5c (Enable minimal stat checking, > 2013-01-22). > > Detecting and complaining now is technically a backwards-incompatible > change, but I don't think anybody has any reason to use an invalid value > here. There are no historical values we'd want to allow for backwards > compatibility or anything like that. We are better off loudly telling > the user that their config may not be doing what they expect. I think this is a good instance of "yes, this is a backwards incompatible change, but the behavior we're breaking is so obviously broken already that it's not worth maintaining compatibility." Well reasoned, I am definitely in favor here. Thanks, Taylor
