On Wed, Dec 6, 2023 at 1:40 PM Patrick Steinhardt <ps@xxxxxx> wrote:
> +static void create_reference_database(const char *initial_branch, int quiet)
> +{
> + struct strbuf err = STRBUF_INIT;
> + int reinit = is_reinit();
> +
> + /*
> + * We need to create a "refs" dir in any case so that older
> + * versions of git can tell that this is a repository.
> + */
How does this work though, even if an earlier version of git can tell
that this is a repository,
it still won't be able to read the reftable backend. In that sense,
what do we achieve here?
> + safe_create_dir(git_path("refs"), 1);
> + adjust_shared_perm(git_path("refs"));
> +
Not related to your commit per se, but we ignore the return value
here, shouldn't we die in this case?
