From: Elijah Newren <newren@xxxxxxxxx> The unnecessary include in the header transitively pulled in some other headers actually needed by source files, though. Have those source files explicitly include the headers they need. Signed-off-by: Elijah Newren <newren@xxxxxxxxx> --- line-log.c | 1 + line-log.h | 2 -- log-tree.c | 1 + 3 files changed, 2 insertions(+), 2 deletions(-) diff --git a/line-log.c b/line-log.c index a878cb7810a..c276ccec549 100644 --- a/line-log.c +++ b/line-log.c @@ -1,4 +1,5 @@ #include "git-compat-util.h" +#include "diffcore.h" #include "line-range.h" #include "hex.h" #include "tag.h" diff --git a/line-log.h b/line-log.h index 4291da8d792..e9dadbc1a58 100644 --- a/line-log.h +++ b/line-log.h @@ -1,8 +1,6 @@ #ifndef LINE_LOG_H #define LINE_LOG_H -#include "diffcore.h" - struct rev_info; struct commit; struct string_list; diff --git a/log-tree.c b/log-tree.c index 504da6b519e..337b9334cdb 100644 --- a/log-tree.c +++ b/log-tree.c @@ -2,6 +2,7 @@ #include "commit-reach.h" #include "config.h" #include "diff.h" +#include "diffcore.h" #include "environment.h" #include "hex.h" #include "object-name.h" -- gitgitgadget
