On Thu, Nov 30, 2023 at 11:18:26AM +0100, Patrick Steinhardt wrote: > > diff --git a/pack-objects.c b/pack-objects.c > > index f403ca6986..1c7bedcc94 100644 > > --- a/pack-objects.c > > +++ b/pack-objects.c > > @@ -151,6 +151,21 @@ void prepare_packing_data(struct repository *r, struct packing_data *pdata) > > init_recursive_mutex(&pdata->odb_lock); > > } > > > > +void free_packing_data(struct packing_data *pdata) > > Nit: shouldn't this rather be called `clear_packing_data`? `free` to me > indicates that the data structure itself will be free'd, as well, which > is not the case. Thanks, that's a good suggestion. I've made the changes locally and will include it in the subsequent round(s) ;-). Thanks, Taylor