On 2023-11-25 10:45, H.Merijn Brand wrote:
As I am used to PR's by now on all OSS projects I am involved in, or use git commits or merges directly on the repo, I *never* use format-patch and/or send-email.
Actually, using email to send patches is quite neat, IMHO, once you get hold of it.
These docs - yes I read them - do not offer a concise cut-n-paste example for people like me. In order to have my relative simple patch submitted (I already had the PR ready, but that came with a huge warning that PR's are not accepted) I did it the way I did it. Now I need to read and learn two new commands> I don't think that is very user-friendly, but that might be just me. Ironically, this patch is about the mail part of git. I suggest adding a small example like # Create the patch basics $ git format-patch --cover-letter -M origin/master -o outgoing # Fix the subject $ $VISUAL outgoing/0000-cover-letter.patch # Send the mail $ git send-email --to=git@xxxxxxxxxxxxxxx outgoing/*
Please note that a cover letter isn't needed unless you're sending a patch series, i.e. unless you're generating and sending more than a single patch at once. Also, fixing the subject line inside the patch files generated by git-format-patch shouldn't be needed in most cases, and commit summaries should be adjusted/rebased instead, if needed.
