On Sun, Sep 24, 2023 at 5:53 AM Josh Soref via GitGitGadget <gitgitgadget@xxxxxxxxx> wrote: > [...] > diff --git a/Documentation/gitweb.conf.txt b/Documentation/gitweb.conf.txt > index 34b1d6e2243..1edabdfef36 100644 > --- a/Documentation/gitweb.conf.txt > +++ b/Documentation/gitweb.conf.txt > @@ -820,7 +820,7 @@ filesystem (i.e. "$projectroot/$project"), `%h` to the current hash > (\'h' gitweb parameter) and `%b` to the current hash base > (\'hb' gitweb parameter); `%%` expands to \'%'. > + > -For example, at the time this page was written, the http://repo.or.cz[] > +For example, at the time this page was written, the https://repo.or.cz[] Given the "at the time this page was written" comment, I'm not sure we should switch to https here. > Git hosting site set it to the following to enable graphical log > (using the third party tool *git-browser*): > + > diff --git a/Documentation/gitweb.txt b/Documentation/gitweb.txt > index af6bf3c45ec..434893595a4 100644 > --- a/Documentation/gitweb.txt > +++ b/Documentation/gitweb.txt > @@ -28,7 +28,7 @@ Gitweb provides a web interface to Git repositories. Its features include: > revisions one at a time, viewing the history of the repository. > * Finding commits which commit messages matches given search term. > > -See http://repo.or.cz/w/git.git/tree/HEAD:/gitweb/[] for gitweb source code, > +See https://repo.or.cz/w/git.git/tree/HEAD:/gitweb/[] for gitweb source code, > browsed using gitweb itself. The suggested link gives a "404 - No such tree". Granted, the http: link also does that, but it'd be nicer to provide a non-broken link, which you can do by stripping the '/[]' from the end of the URL. > diff --git a/json-writer.h b/json-writer.h > index 209355e0f12..de140e54c98 100644 > --- a/json-writer.h > +++ b/json-writer.h > @@ -3,7 +3,7 @@ > > /* > * JSON data structures are defined at: > - * [1] http://www.ietf.org/rfc/rfc7159.txt > + * [1] https://www.ietf.org/rfc/rfc7159.txt > * [2] http://json.org/ As Eric commented on v1, the json.org link should also be converted to https. The rest of the patch that I didn't comment on looks fine.
