"Victoria Dye via GitGitGadget" <gitgitgadget@xxxxxxxxx> writes: > This consolidates much of the code used to filter and format refs in > 'builtin/for-each-ref.c', 'builtin/tag.c', and 'builtin/branch.c', reducing > duplication and simplifying the future changes needed to optimize the filter > & format process. > > Signed-off-by: Victoria Dye <vdye@xxxxxxxxxx> > --- > builtin/branch.c | 33 +++++++++++++++++---------------- > builtin/for-each-ref.c | 27 +-------------------------- > builtin/tag.c | 23 +---------------------- > ref-filter.c | 35 +++++++++++++++++++++++++++++++++++ > ref-filter.h | 14 ++++++++++++++ > 5 files changed, 68 insertions(+), 64 deletions(-) The amount of existing duplication of code is rather surprising, and this patch nicely refactors to improve. Good. Thanks.