Re: [PATCH] remote-curl: avoid hang if curl asks for more data after eof

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> Is this a bug on our side, or cURL library calling us when it should not?

I thought the same and yes, I suppose it _might_ be potentially considered
a bug on cURL side in the first place. But then also

1/ it is not mandated anywhere in the API that the callback will never be
   called again after already getting an EOF once,

2/ I looked at libcurl code and it was not entirely clear to me that the
   behavior would be accidental, that it could be clearly called as a bug,

3/ anything that follows how fread() works would never be affected,
   but git-remote-curl is, because it does something differently,

4/ even if it gets fixed in libcurl today, people might be building Git with
   whatever old versions of the library for years to come,

so worth fixing here in any case (imho).

But I'll reach out to curl-library and get their opinion, so that we have
a full picture here. Thanks




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux