On Mon, Nov 13, 2023 at 06:50:08PM -0800, Elijah Newren wrote: > merge-tree is the same as far as hooks; I'd rather just not have them, > but if we did, they'd be a post-operation hook. > > In both cases, that makes hooks not much of a sticking point. > > External merge drivers, however... I suspect external merge drivers are OK, in the sense that they should not be looking up arbitrary objects anyway. We should hand the driver what it needs via tempfiles, etc. That said, I'm also OK with the notion that "--write-pack" is optional, and if some features don't work with it, that's OK. It's nice if we can flag that explicitly (rather than having things break in weird and subtle ways), but I think we might not even know about an implicit assumption until somebody runs across it in practice. -Peff
