On Mon, 29 Oct 2007, Shawn O. Pearce wrote:
> Daniel Barkalow <barkalow@xxxxxxxxxxxx> wrote:
> > -int main(int argc, char **argv)
> > +void setup_send_pack(struct send_pack_args *args)
> > +{
> > + receivepack = args->receivepack;
> > + verbose = args->verbose;
> > + send_all = args->send_all;
> > + force_update = args->force_update;
> > + use_thin_pack = args->use_thin_pack;
> > + dry_run = args->dry_run;
> > +}
> ...
> > +struct send_pack_args {
> > + const char *receivepack;
> > + int verbose;
> > + int send_all;
> > + int force_update;
> > + int use_thin_pack;
> > + int dry_run;
> > +};
> > +
>
> Ick. How about doing what I did with builtin-fetch-pack.c which
> was to copy the args into a global "static struct fetch_pack_args"
> and make the struct a bitfield with these boolean items as ":1"
> rather than a full int?
Yeah, that's better. I'll respin parts 3 and 4 that way.
-Daniel
*This .sig left intentionally blank*
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
