"brian m. carlson" <sandals@xxxxxxxxxxxxxxxxxxxx> writes: > I'd generally want to look at the commit message and understand the > problem the code is trying to solve and then look at the code and think, > "Oh, yes, this seems like the obvious and logical way to solve this > problem," or at least think, "Oh, no, I think we should solve this > problem in a different way," so I can help make a thoughtful review > comment. Right now, I lack the information to have an informed opinion > and so I can't provide any helpful feedback or analysis of the patches. > ... > I'd recommend a quick pass over the SubmittingPatches file, which is > also available at https://git-scm.com/docs/SubmittingPatches. The > sections on making separate commits for separate changes and describing > changes well come to mind as places to focus. > > I know this may seem overwhelming and like I'm upset or disappointed; > I'm definitely not. I'm very much interested in seeing Git available > for more platforms, but right now it's too hard for me to reason about > the changes for z/OS to provide helpful feedback, so I'm hoping you can > send a fixed v2 that helps me (and everyone else) understand these > changes better so you can get a helpful review. All very good pieces of advice. I suspect we are missing some of them from our SubmittingPatches or CodingGuidelines documents and may want to add them there. Thanks.
