Jeff King <peff@xxxxxxxx> writes: > On Fri, Nov 10, 2023 at 11:01:15AM +0100, Patrick Steinhardt wrote: > >> diff --git a/t/valgrind/valgrind.sh b/t/valgrind/valgrind.sh >> index 669ebaf68be..9fbf90cee7c 100755 >> --- a/t/valgrind/valgrind.sh >> +++ b/t/valgrind/valgrind.sh >> @@ -23,7 +23,7 @@ memcheck) >> VALGRIND_MAJOR=$(expr "$VALGRIND_VERSION" : '[^0-9]*\([0-9]*\)') >> VALGRIND_MINOR=$(expr "$VALGRIND_VERSION" : '[^0-9]*[0-9]*\.\([0-9]*\)') >> test 3 -gt "$VALGRIND_MAJOR" || >> - test 3 -eq "$VALGRIND_MAJOR" -a 4 -gt "$VALGRIND_MINOR" || >> + ( test 3 -eq "$VALGRIND_MAJOR" && test 4 -gt "$VALGRIND_MINOR" ) || >> TOOL_OPTIONS="$TOOL_OPTIONS --track-origins=yes" > > I was surprised to see this one as a subshell after you adjusted the > other. ;-) I am not so surprised that this one was missed, though. I didn't point this one out during my review of the previous round, either, and not everybody is as careful as you are. Thanks, both.
