On Thu, Nov 09, 2023 at 02:03:10AM -0500, Jeff King wrote: > This is a follow-up to the series from: > > https://lore.kernel.org/git/20231009205544.GA3281950@xxxxxxxxxxxxxxxxxxxxxxx/ > > which was merged to master as jk/chunk-bounds. There were a few issues > left open by that series and its review: > > 1. the midx code didn't check fanout ordering > > 2. whether we needed to sprinkle some more st_mult() on it > > 3. improving some of the error messages (translations, some > consistency, maybe more details) > > 4. possible refactoring with a pair_chunk_expect() API (Taylor posted > a series in that direction, which is currently in limbo) I read this series thoroughly and was very pleased with the result. Thanks for patching these up. I think that I am still of the mind that it would be useful to have some kind of pair_chunk_expect() function, so I'll try and rebase/rewrite my patches on top of your new ones here. In the meantime, this series LGTM. Thanks, Taylor
