On Thu, Nov 09, 2023 at 08:09:47AM +0100, Patrick Steinhardt wrote: > this is the third version of my patch series to improve compatibility of > our tests with NixOS. > > Changes compared to v2: > > - Patch 1: We now check for both httpd and apache2 binaries via > PATH. > > - Patch 1: We're a bit more defensive and will check whether > variables are empty before passing them to either `test -d` or > `test -x`. > > - Patch 3: Clarified why PATH is unset. > > - Patch 3: Instead of writing PATH into the hook we now write it > into the `hook-env` configuration file read by Subversion. Thanks. This looks good to me, modulo a minor shell nit I mentioned in the first patch. -Peff
