On Thu, Nov 09, 2023 at 02:43:02AM +0900, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > ... But the more robust way to do it is: > > > > # export ORIG_PATH, which presumably is not cleared the same way PATH > > # is, so that the hook can access it > > ORIG_PATH=$PATH && > > export ORIG_PATH && > > > > cat >"$hook" <<EOF > > # pull the original path from the caller > > PATH=$ORIG_PATH > > export PATH > > > > ...do other stuff... > > EOF > > > > That's assuming that environment variables make it intact to the hook at > > all (it is not clear to me why the original $PATH doesn't). > > Yeah, the parenthetical comment points at the crux of the issue. I > can tell from the patch what issue the platform throws at us we are > trying to work around, but it is frustrating not to know why the > platform does such unpleasant things in the first place. > > Thanks. Indeed, I should've described this better in the commit message. Quoting [1]: > By default, Subversion executes hook scripts with an empty > environment—that is, no environment variables are set at all, not even > $PATH (or %PATH%, under Windows). Because of this, many administrators > are baffled when their hook program runs fine by hand, but doesn't > work when invoked by Subversion. Administrators have historically > worked around this problem by manually setting all the environment > variables their hook scripts need in the scripts themselves. So it's not an issue of the environment, but rather an implementation detail of how Subversion hooks work. It's surprising that this does not fail on other platforms -- maybe the shell has a default PATH there that allow us to locate basename(1)? I dunno. Will add to the commit message. Patrick [1]: https://svnbook.red-bean.com/en/1.8/svn.reposadmin.create.html#svn.reposadmin.create.hooks
Attachment:
signature.asc
Description: PGP signature
