On Mon, Oct 29, 2007 at 07:45:26AM +0000, Lars Knoll wrote: > +static int no_wildcard(const char *string) > +{ > + return !strchr(string, '*') && !strchr(string, '?') > && !strchr(string, '[') && !strchr(string, '{'); return string[strcspn(string, "*?[{")] == '\0'; is faster as it doesn't scan the string 4 time in the case where there is no wildcard. > +} > + > void add_exclude(const char *string, const char *base, > int baselen, struct exclude_list *which) > { > struct exclude *x = xmalloc(sizeof (*x)); > > + x->to_exclude = 1; You used spaces in here, and in many places of your patch. -- ·O· Pierre Habouzit ··O madcoder@xxxxxxxxxx OOO http://www.madism.org
Attachment:
pgpYwSoHAABKC.pgp
Description: PGP signature