Victoria Dye <vdye@xxxxxxxxxx> writes: > As for adding the GitLab-specific stuff, I'm not opposed to having it in the > main tree. For one, there doesn't seem to be a clean way to "move it into > `contrib/`" - '.gitlab-ci.yml' must be at the root of the project [2], and > moving the $GITLAB_CI conditions out of the 'ci/*.sh' files into dedicated > scripts would likely result in a lot of duplicated code (which doesn't solve > the maintenance burden issue this series intends to address). > > More generally, there are lots of open source projects that include CI > configurations across different forges, _especially_ those that are > officially mirrored across a bunch of them. As long as there are > contributors with a vested interest in keeping the GitLab CI definition > stable (and your cover letter indicates that there are), and the GitLab > stuff doesn't negatively impact any other CI configurations, I think it > warrants the same treatment as e.g. GitHub CI. Thanks for expressing this so clearly. I do prefer to add this as the first class citizen (more generally, I do not want to add new things to contrib/ at this point) if we are going to use it.
