Junio C Hamano <gitster@xxxxxxxxx> writes: > This moving of the helper function does not belong to the "fix > commented_addf() not to take the comment_line_char" step. > > The series should be restructured to have the two patches from me > first, and then your moving some stuff to environment.c, probably. This means that #include "environment.h" will be added and then removed in the same series, but I don't feel too strongly about that. I'll send an updated set of patches.