On Tue, Oct 31, 2023 at 03:24:11PM -0400, Taylor Blau wrote: > Back in 32f3c541e3 (multi-pack-index: write pack names in chunk, > 2018-07-12) the MIDX's "Packfile Names" (or "PNAM", for short) chunk was > described as containing an array of string entries. e0d1bcf825 notes > that this is the only chunk in the MIDX format's specification that is > not guaranteed to be 4-byte aligned, and so should be placed last. > > This isn't quite accurate: the entries within the PNAM chunk are not > guaranteed to be 4-byte aligned since they are arbitrary strings, but > the chunk itself is 4-byte aligned since the ending is padded with NUL > bytes. We also don't place it last! :) So the alignment is very important, as I found out in the recent chunk-corruption series. > So these have always been externally aligned. Correct the corresponding > part of our documentation to reflect that. Both this and the previous patch look good to me. -Peff
