On 2023-10-28 17:21, Jacob Stopak wrote:
On Sat, Oct 28, 2023 at 07:55:31AM +0200, Dragan Simic wrote:
Basically what I'm asking is if commands that already have a
--verbose
flag would just get a config setting that does the existing thing by
default?
Well, not by default. The default values would remain "false", so
nothing
jumps out of nowhere.
Right, sorry, I worded that poorly.
No worries, just wanted to make sure we're on the same page.
Yes, that's what I propose. It also looks like a logical choice to
me, and
it would leave space for some possible later changes to the
"<command>.verbose = extended" verbosity, without tying it to the
tables.
We'd also leave some space that way for even maybe an additional level
of
verbosity, be it "<command>.verbose = simple", "<command>.verbose =
graphical" or whatever.
Perhaps this scheme should also support "<command>.verbose = basic",
which
would be an alias for "<command>.verbose = true", for additional
clarity.
Sounds good!
I'm glad you agree.
Perhaps it would also be good to nudge the newbies a bit by requesting
them
to enable the extended verbosity for each command by hand. That way
they
would both learn a bit about the way git configuration works, which
they
ultimately can't escape from, and they would be excited to learn new
git
commands. Or I at least hope so. :)
Hehe ok, maybe there is room in some hints to notify users of the
extended option...
I agree, there should be a well-placed hint, but we'd need to think
really well where to place it, so we don't annoy experienced git users
too much, while we also inform the less experienced users.
> Any thoughts on what the section in the config for a more general
> setting like this might be named?
Maybe "core.verbose"? We already have "core.pager", which kind of
affects
the way all command outputs look like.
Ok! The idea of using "core" came to mind but I wasn't sure if that was
more for lower-level settings or more general things.
I also considered the "core" section to be reserved for the very
low-level internal things, but having "core.pager" clearly allows other
appropriate configuration options to be placed here.
Great. Thanks a lot for all the feedback. Let me doctor up the patch
series to take these things into account and submit an RFC v3 :D
Sounds good, thank you. If you agree, I'll go ahead and implement
support for a few "<command>.verbose" configuration options during the
next week or so, and submit the patches. I'll most probably come to
some more important conclusions while implementing that, which I'll
relay over, of course.