On 27/10/2023 12:01, Oswald Buddenhagen wrote:
On Fri, Oct 27, 2023 at 11:25:41AM +0200, Patrick Steinhardt wrote:
+ export GIT_PROVE_OPTS="--timer --jobs $(nproc)"
+ export GIT_TEST_OPTS="--verbose-log -x"
fwiw (as this is again only copied), export with assignment is a
bash-ism
Not according to
https://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#export
SYNOPSIS
export name[=word]...
DESCRIPTION
The shell shall give the export attribute to the variables
corresponding to the specified names, which shall cause them
to be in the environment of subsequently executed commands. If
the name of a variable is followed by = word, then the value
of that variable shall be set to word.
It is true that in our test suite we separate a variable assignment when
exporting. Presumably that is because someone reported that their shell
did not support the "export name=WORD" syntax in the past. As we're
already using this syntax with the same docker images in Github Actions
I think we can assume it is safe here.
Best Wishes
Phillip
