On Fri, Oct 27, 2023 at 11:22:35AM +0100, Phillip Wood wrote:
On 27/10/2023 09:17, Patrick Steinhardt wrote:
+ CI_BRANCH="$CI_COMMIT_REF_NAME"
+ CI_COMMIT="$CI_COMMIT_SHA"
assignments need no quoting to prevent word splitting.
repeats below.
+ case "$CI_JOB_IMAGE" in
... as does the selector in case statements.
True, but I'm simply matching the coding style in this script.
I think it is quite common for us to quote variables when it isn't
strictly necessary as it makes it clear to anyone reading the script
that there is no word splitting going on
and ensures that we don't start splitting the variable if the contents
changes in the future.
the point was that it *isn't* content-dependent; it's simply the shell
rules. of course, many people (apparently you included) don't know these
subtleties, so just quoting everything isn't the worst idea (though it
would backfire with some *really* old buggy shells, but this doesn't
need to concern us).
regards
