On Thu, Oct 26, 2023 at 6:41 PM Emily Shaffer <nasamuffin@xxxxxxxxxx> wrote: > On Thu, Oct 26, 2023 at 3:12 PM Eric Sunshine <sunshine@xxxxxxxxxxxxxx> wrote: > > On Thu, Oct 26, 2023 at 7:10 AM Bagas Sanjaya <bagasdotme@xxxxxxxxx> wrote: > > > On Thu, Oct 26, 2023 at 07:49:58AM +1100, Sheik wrote: > > > > Running git diagnose with an invalid CLI argument in a valid Git directory > > > > does not report error. Expected behaviour would be that it reports an error. > > > > > > I can reproduce this only when the invalid parameter is a normal word: > > > Cc:'ing people who recently worked on builtin/diagnose.c for help. > > > > A patch by Emily to fix this has been submitted[v4]. > > To be clear, that patch was for git-bugreport and doesn't cover > git-diagnose. I assume the fix ends up being pretty similar though. My bad.
