Re: [PATCH 1/5] ci: reorder definitions for grouping functions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Oct 26, 2023 at 10:00:03AM +0200, Patrick Steinhardt wrote:
[...]
_not_ being GitLab Actions, where we define the non-stub logic in the

you meant GitHub here.

else branch.

Reorder the definitions such that we explicitly handle GitHub Actions.

i'd say something like "the conditional branches". imo that makes it clearer that you're actually talking about code, not some markup or whatever. for that matter, this is my overall impression of the commit message - it seems way too detached from the near-trivial fact that you're just slightly adjusting the code structure to make it easier to implement a cascade (aka a switch).

regards




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux