On Wed, Oct 25, 2023, at 07:38, Patrick Steinhardt wrote: >> What do you guys think the signature of `git_global_config` should be? > > Either of the following: > > - `int git_global_config(char **out_pat)` > - `char **git_global_config(void)` > > In the first case you'd signal error via a non-zero return value, > whereas in the second case you would signal it via a `NULL` return > value. > > To decide which one to go with I'd recommend to check whether there is > any similar precedent in "config.h" and what style that precedent uses. Okay thanks. So no parameter for determining whether one is writing or just reading the file. Cheers -- Kristoffer Haugsbakk