Re: [PATCH 5/8] push, send-pack: support pushing HEAD to real ref name

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 




On Oct 28, 2007, at 8:28 AM, Junio C Hamano wrote:

Steffen Prohaska <prohaska@xxxxxx> writes:

This teaches "push <remote> HEAD" to resolve HEAD on the local
side to its real ref name, e.g. refs/heads/master, and then
use the real ref name on the remote side to search a matching
remote ref.

This probably is a good idea.

I'll think about Daniel's suggestion of implementing it
differently.


+	if (real_name) {
+		free(real_name);
+	}

Excess and unnecessary brace pair.

When are excess and unnecessary braces acceptable?
Is

	if (something) {
 		printf("text %d"
  		       "more text %d"
                       "and even more %d\n"
		       , a, b, c);
	}

ok? Or should I avoid braces there, too?

	Steffen
-
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html

[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux