On Fri, Oct 20, 2023 at 02:45:30PM -0700, Junio C Hamano wrote: > Jeff King <peff@xxxxxxxx> writes: > > > - the handling for to/cc/bcc is totally broken. > > It is good to see another evidence that "--compose" is probably not > as often as used as we thought. With enough bugs discovered, > perhaps someday we can declare "it cannot be that the feature is > used in the wild, without anybody getting hit by these bugs---let's > deprecate and eventually remove it" ;-) I'm not sure if that is evidence or not. The to/cc/bcc feature was just never implemented. The commit from 2017 made it more broken than saying "not yet implemented", but that may only be an indication that nobody wants it or tried to use it. I dunno. As I noted, the same feature exists when reading the cover-letter from a set of format-patch files. And of course it is implemented using totally separate code (in pre_process_file). One possible cleanup would be to unify those two, but I'm sure there would be behavior changes. Some of them perhaps good (e.g., it looks like pre_process_file is more careful about rfc2047 handling) and some of them I'm not so sure of (e.g., support for --header-cmd in the --compose letter). I think an interested person could champion such changes, but I am not that interested in send-email (I don't use it, and some of its code is pretty ancient and gross). My goal was to fix the bug I saw with minimal regression (I waffled even on my patch 2). -Peff
