Matthew McClain <mmcclain@xxxxxxxxxxx> writes: > git-p4.py would attempt to put a symlink in LFS if its file extension > matched git-p4.largeFileExtensions. > > Git LFS doesn't store symlinks because smudge/clean filters don't handle > symlinks. They never get passed to the filter process nor the > smudge/clean filters, nor could that occur without a change to the > protocol or command-line interface. Unless Git learned how to send them > to the filters, Git LFS would have a hard time using them in any useful > way. > > Git LFS's goal is to move large files out of the repository history, and > symlinks are functionally limited to 4 KiB or a similar size on most > systems. Reads much better and easier to reason about. Will queue and see if "git p4" stakeholders object for a few days; if nothing happens, let's merge it down to 'next' and then to 'master' as usual. Thanks. > Signed-off-by: Matthew McClain <mmcclain@xxxxxxxxxxx> > --- > git-p4.py | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/git-p4.py b/git-p4.py > index d26a980e5a..0eb3bb4c47 100755 > --- a/git-p4.py > +++ b/git-p4.py > @@ -1522,6 +1522,10 @@ def processContent(self, git_mode, relPath, contents): > file is stored in the large file system and handles all necessary > steps. > """ > + # symlinks aren't processed by smudge/clean filters > + if git_mode == "120000": > + return (git_mode, contents) > + > if self.exceedsLargeFileThreshold(relPath, contents) or self.hasLargeFileExtension(relPath): > contentTempFile = self.generateTempFile(contents) > pointer_git_mode, contents, localLargeFile = self.generatePointer(contentTempFile)
