Phillip Wood <phillip.wood123@xxxxxxxxx> writes:
> From: Phillip Wood <phillip.wood@xxxxxxxxxxxxx>
>
> Here are a couple of cleanups for the unit test framework that I
> noticed.
Thanks. I trust that this will be squashed into the next update,
but in the meantime, I'll include it in the copy of the series I
have (without squashing). Here is another one I noticed.
----- >8 --------- >8 --------- >8 -----
Subject: [PATCH] fixup! ci: run unit tests in CI
A CI job failed due to contrib/coccinelle/equals-null.cocci
and suggested this change, which seems sensible.
Signed-off-by: Junio C Hamano <gitster@xxxxxxxxx>
---
t/unit-tests/t-strbuf.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/unit-tests/t-strbuf.c b/t/unit-tests/t-strbuf.c
index c2fcb0cbd6..8388442426 100644
--- a/t/unit-tests/t-strbuf.c
+++ b/t/unit-tests/t-strbuf.c
@@ -28,7 +28,7 @@ static void setup_populated(void (*f)(struct strbuf*, void*), char *init_str, vo
static int assert_sane_strbuf(struct strbuf *buf)
{
/* Initialized strbufs should always have a non-NULL buffer */
- if (buf->buf == NULL)
+ if (!buf->buf)
return 0;
/* Buffers should always be NUL-terminated */
if (buf->buf[buf->len] != '\0')
--
2.42.0-398-ga9ecda2788
