Re: [PATCH 0/2] [Outreachy][PATCH v2] branch.c: adjust error messages to coding guidelines

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 13-oct-2023 15:33:45, Isoken June Ibizugbe via GitGitGadget wrote:

> As per the CodingGuidelines document, it is recommended that a single-line
> message provided to error messages such as die(), error() and warning(),
> should start with a lowercase letter and should not end with a period.
> 
> Signed-off-by: Isoken June Ibizugbe isokenjune@xxxxxxxxx
> 
> Isoken June Ibizugbe (2):
>   branch.c: ammend error messages for die()
>   branch.c: adjust error messages to coding guidelines

I don't understand why two commits.  Maybe it was unintentional and you
want to merge all changes into one commit, using git rebase.

> 
>  builtin/branch.c | 66 ++++++++++++++++++++++++------------------------
>  1 file changed, 33 insertions(+), 33 deletions(-)

You still need to adjust the tests.  Take a look at:

https://github.com/git/git/actions/runs/6509642887/job/17681596358




[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux