Re: [PATCH 08/20] midx: enforce chunk alignment on reading

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Oct 09, 2023 at 05:05:23PM -0400, Jeff King wrote:
> ---
>  chunk-format.c              |  8 +++++++-
>  chunk-format.h              |  3 ++-
>  commit-graph.c              |  2 +-
>  midx.c                      |  3 ++-
>  t/t5319-multi-pack-index.sh | 14 ++++++++++++++
>  5 files changed, 26 insertions(+), 4 deletions(-)

Very nicely written and explained. I agree that the choice you made here
(to validate the alignment in the chunk-format API itself when reading
the table of contents) feels more sensible and places less burden on the
callers.

LGTM, let's keep reading...

Thanks,
Taylor



[Index of Archives]     [Linux Kernel Development]     [Gcc Help]     [IETF Annouce]     [DCCP]     [Netdev]     [Networking]     [Security]     [V4L]     [Bugtraq]     [Yosemite]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Linux SCSI]     [Fedora Users]

  Powered by Linux