On Tue, Oct 10, 2023 at 7:09 PM Junio C Hamano <gitster@xxxxxxxxx> wrote: > > Patrick Steinhardt <ps@xxxxxx> writes: > > > I had already reviewed the patches internally at GitLab, so for what > > it's worth please feel free to add my Reviewed-by. > > Great. It seems that 'seen' with this series fails to pass the > tests, though. > > https://github.com/git/git/actions/runs/6462854176/job/17545104753 Seems like this is because of commit-graph being enabled, I think the best thing to do here would be to disable the commit graph of these tests. This should do: diff --git a/t/t6022-rev-list-missing.sh b/t/t6022-rev-list-missing.sh index bbff66e4fc..39a8402682 100755 --- a/t/t6022-rev-list-missing.sh +++ b/t/t6022-rev-list-missing.sh @@ -5,6 +5,11 @@ test_description='handling of missing objects in rev-list' TEST_PASSES_SANITIZE_LEAK=true . ./test-lib.sh +# Disable writing the commit graph as the tests depend on making particular +# commits hidden, the graph is created before that and rev-list would default +# to using the commit graph in such instances. +GIT_TEST_COMMIT_GRAPH=0 + # We setup the repository with two commits, this way HEAD is always # available and we can hide commit 1. test_expect_success 'create repository and alternate directory' ' Thanks for reporting. I'll wait for a day or two (for reviews) and will add this to the second version of this series.
