Phillip Wood <phillip.wood123@xxxxxxxxx> writes: >> I'm open to changing >> git_config_get_expiry_date_in_days() too, though...we probably don't >> need so many days. > > Indeed, the existing code passes maximum_signed_value_of_type(int) as > the third argument to limit it to INT_MAX already. Yeah, in other words, the current implementation does not allow us to express the days more than an int can, so it is no brainer to switch to use git_parse_int(). Allowing longer expiration period is obviously outside the scope of this series. Thanks.