phillip.wood123@xxxxxxxxx writes: > Hi Jonathan > > On 29/09/2023 22:20, Jonathan Tan wrote: > > Calvin will be away for a few weeks and I'll be handling the git-std-lib > > effort in the meantime. My goals will be: > > > > - Get the preliminary patches in Calvin's patch set (patches 1-4) merged > > first. > > > > - Updating patches 5-6 based on reviewer feedback (including my > > feedback). I have several aims including reducing or eliminating the > > need for the GIT_STD_LIB preprocessor variable, and making stubs a test- > > only concern (I think Phillip has some similar ideas [1] but I haven't > > looked at their repo on GitHub yet). > > It sounds like we're thinking along similar lines, do feel free get in > touch on or off the list if you want to ask anything about those patches > I pushed to github. Thanks. I'm updating patches 5-6 now and basing on your work, in fact. > > [1] https://lore.kernel.org/git/98f3edcf-7f37-45ff-abd2-c0038d4e0589@xxxxxxxxx/ > > > > This patch set is in service of the first goal. Because the libification > > patches are no longer included in this patch set, I have rewritten the > > commit messages to justify the patches in terms of code organization. > > There are no changes in the code itself. Also, I have retained Calvin's > > name as the author. > > I agree it makes sense to get the preliminary patches merged on their > own. I think the argument that they reduce the scope of includes is a > reasonable justification on its own. I've left a couple of comments but > they're looking pretty good. > > Best Wishes > > Phillip Thanks.
